Narrative API #17
Merged
Narrative API #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaidevd
commented
Jan 16, 2020
nlg/grammar.py
Outdated
| @@ -237,10 +237,11 @@ def find_inflections(text, search, fh_args, df): | |||
| tmpl = [t['tmpl'] for t in tklist if t.get('enabled', False)][0] | |||
| rendered = Template('{{{{ {} }}}}'.format(tmpl)).generate( | |||
| df=df, fh_args=fh_args).decode('utf8') | |||
| if rendered != token: | |||
| if rendered != getattr(token, "text", token): | |||
There was a problem hiding this comment.
Quants and fh_args are still not ported over to spacy tokens and spans - which has necessitated this.
nlg/grammar.py
Outdated
| if infl: | ||
| inflections[token] = [infl] | ||
| inflections[token.text] = [infl] |
There was a problem hiding this comment.
This will fail if token is a string. Ensure #15 is fixed.
| @@ -195,8 +265,29 @@ def search_quant(self, quants, nround=2, cell_fmt='df["{}"].iloc[{}]'): | |||
| 'location': 'cell', 'tmpl': cell_fmt.format(self.df.columns[y], x), | |||
| 'type': 'quant'} | |||
|
|
|||
| def search_derived_quant(self, quants, nround=2): | |||
| dfix.update(search_args(dfs.ents, args)) | ||
| dfix.clean() | ||
| inflections = grammar.find_inflections(clean_text, dfix, args, df) | ||
| inflections = grammar.find_inflections(text.text, dfix, args, df) |
There was a problem hiding this comment.
This should not be necessary. Inflections should work with tokens / spans
| return narrative.Nugget(clean_text, dfix, infl, args) | ||
|
|
||
|
|
||
| def add_manual_template(input_template, manual_template=None): |
| @@ -228,3 +228,28 @@ def add_html_styling(template, style): | |||
| ss=spanstyle, token=token) | |||
| template = re.sub(re.escape(token), repl, template, 1) | |||
| return '<p>{template}</p>'.format(template=template) | |||
|
|
|||
|
|
|||
| def infer_quant(token): | |||
There was a problem hiding this comment.
This should be replaced with numerizer.
Add example notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the Narrative API which allows manual setting of variables in templates. Other changes include: