Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMDB ratings data is not getting templatised #40

Closed
mankoven opened this issue Feb 10, 2020 · 1 comment
Closed

IMDB ratings data is not getting templatised #40

mankoven opened this issue Feb 10, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@mankoven
Copy link
Collaborator

While creating nuggets using IMDB rating data, none of the nugget text is being autodetected.
@jaidevd jaidevd added the bug Something isn't working label Feb 10, 2020
jaidevd added a commit that referenced this issue Feb 11, 2020
@jaidevd
FIX: Handle short strings better
0a21887 
Input strings that are shorter than the longest string in the dataset
were force-searched literally. Removed this condition. See #40.
@jaidevd jaidevd mentioned this issue Feb 11, 2020
Merged
jaidevd added a commit that referenced this issue Feb 11, 2020
@jaidevd
FIX: Handle short strings better (#44)
0e1e53a 
Input strings that are shorter than the longest string in the dataset
were force-searched literally. Removed this condition. See #40.
@jaidevd
Copy link
Member

jaidevd commented Feb 11, 2020

image

Fixed in #44 - please check once, @mankoven

@jaidevd jaidevd closed this as completed Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaidevd @mankoven