2) Make Rust FaustDsp Trait Optional #1080
Conversation
crop2000
force-pushed
the
rust_trait_optional
branch
from
31596ac
to
1c38dcf
Compare
tests/impulse-tests/Makefile
Outdated
| @@ -362,13 +362,13 @@ interp1: | |||
| ######################################################################### | |||
| # Rust backend | |||
| rust: | |||
| $(MAKE) -f Make.rust FAUSTOPTIONS="-I dsp -double" | |||
| $(MAKE) -f Make.rust FAUSTOPTIONS="-I dsp -double -rnt" | |||
There was a problem hiding this comment.
In my opinion the CI should always use the mode that generates code against the trait.
As explained in the old PR, this largely reduces the risk of making an accidental breaking change. If the CI no longer runs against the trait based generation it would become rather easy to open a PR and merge it, and by accident breaks the interface in a fundamental way.
Personally I would prefer if -ec and -os would also use their own traits instead to clearly communicate what the stable interface of these modes is.
There was a problem hiding this comment.
Ok i will setup different combinations of flags for the tests.
I don't want to work on faust generating traits now because i think traits are a separate problem to solve. People who want a simple way of using faust with rust can just use less flags.
crop2000
force-pushed
the
rust_trait_optional
branch
from
1c38dcf
to
535a2fd
Compare
|
rebased on top of #1077 |
crop2000
changed the title
This PR introduces the new compile flag
-rnt--rust-no-faustdsp-traitto faust, to not generate the FaustDsp interface.The aim is to be able to make use of flags like
-ecor-osthat change the generated code so that it is not compatible with the FaustDsp trait.@bluenote10
@obsoleszenz