-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2b) add cpp and rust tests on ci #1073
base: master-dev
Are you sure you want to change the base?
Conversation
e5ca800
to
a148222
Compare
.github/workflows/ubuntu.yml
Outdated
|
||
- name: Run impulse tests (C++) | ||
run: cd tests/impulse-tests && make travis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that the target is called "travis" (tests don't run on Travis CI, no?). But of course that's somewhat independent of this PR, if it happens to be called like this already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a subset of the cpp tests that finishes in below 1h
@sletz what do you think about this? |
This is too long, I suggest modifying the |
@sletz is the travis target used elsewhere? if not i would rename it to github_action and describe a meaning full subset. maybe it makes sense to have a detailed check that is not part of the default actions, but can be activated to ensure a thorough check for more complex changes. |
@sletz down to ~20m for everything ~5min build faust, ~15min c++ and rust |
setup github action to run tests the tests needed some changed to work on github remove prefix ir from gcc tests remove constant.dsp ir from gcc mapp tests improve rust impule_test makefile
based on #1068
a lot of work was caused by #1075