First pass #1
Draft
First pass #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ospencer do you think I should squash some of these commits where I was experimenting? Also, what should we try to get done before making this the base of the project (I know of multiple return results, maybe exceptions instead of options)? |
|
Tracking these URLs for myself: |
|
@phated I completely missed your comment on this. Yes, let's squash the experimental commits. I don't think we really need to do much in terms of changing things before merging; I think anything else that we want to do can be done in follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft PR for now.
This is all the work we did to start building the low-level bindings.
CI won't work because I left a bunch of the large files out of the repo until we figure out how to vendor them, etc.