Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Upgrade to libbinaryen v114 #87

Merged
merged 5 commits into from
Oct 24, 2023
Merged

feat!: Upgrade to libbinaryen v114 #87

merged 5 commits into from
Oct 24, 2023

Conversation

peblair
Copy link
Member

@peblair peblair commented Oct 22, 2023

binaryen-c.h diff:

(empty)

passes/pass.cpp diff:

diff --git a/src/passes/pass.cpp b/src/passes/pass.cpp
index ff2c7d45f..adaa42e04 100644
--- a/src/passes/pass.cpp
+++ b/src/passes/pass.cpp
@@ -464,6 +464,7 @@ void PassRegistry::registerPasses() {
   registerPass("strip-producers",
                "strip the wasm producers section",
                createStripProducersPass);
+  registerPass("strip-eh", "strip EH instructions", createStripEHPass);
   registerPass("strip-target-features",
                "strip the wasm target features section",
                createStripTargetFeaturesPass);
@@ -697,9 +698,6 @@ void PassRunner::run() {
   assert(!ran);
   ran = true;
 
-  // As we run passes, we'll notice which we skip.
-  skippedPasses.clear();
-
   static const int passDebug = getPassDebug();
   // Emit logging information when asked for. At passDebug level 1+ we log
   // the main passes, while in 2 we also log nested ones. Note that for
@@ -820,20 +818,6 @@ void PassRunner::run() {
     }
     flush();
   }
-
-  if (!isNested) {
-    // All the passes the user requested to skip should have been seen, and
-    // skipped. If not, the user may have had a typo in the name of a pass to
-    // skip, and we will warn. (We don't do this in a nested runner because
-    // those are used for various internal tasks inside passes, which would lead
-    // to many spurious warnings.)
-    for (auto pass : options.passesToSkip) {
-      if (!skippedPasses.count(pass)) {
-        std::cerr << "warning: --" << pass << " was requested to be skipped, "
-                  << "but it was not found in the passes that were run.\n";
-      }
-    }
-  }
 }
 
 void PassRunner::runOnFunction(Function* func) {
@@ -955,7 +939,6 @@ void PassRunner::runPass(Pass* pass) {
   assert(!pass->isFunctionParallel());
 
   if (options.passesToSkip.count(pass->name)) {
-    skippedPasses.insert(pass->name);
     return;
   }
 
@@ -979,7 +962,6 @@ void PassRunner::runPassOnFunction(Pass* pass, Function* func) {
   assert(pass->isFunctionParallel());
 
   if (options.passesToSkip.count(pass->name)) {
-    skippedPasses.insert(pass->name);
     return;
   }
 

CMakeLists.txt diff:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index ca8d44933..8a008b514 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -7,7 +7,7 @@ cmake_minimum_required(VERSION 3.10.2)
 # to reduce this for compatability with emsdk.
 set(CMAKE_OSX_DEPLOYMENT_TARGET "10.14" CACHE STRING "Minimum OS X deployment version")
 
-project(binaryen LANGUAGES C CXX VERSION 113)
+project(binaryen LANGUAGES C CXX VERSION 114)
 include(GNUInstallDirs)
 
 # The C++ standard whose features are required to build Binaryen.

@peblair peblair requested a review from phated October 22, 2023 18:48
@phated phated changed the title Update to binaryen v114 feat!: Upgrade to libbinaryen v114 Oct 24, 2023
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phated phated merged commit cb7574b into main Oct 24, 2023
27 checks passed
@phated phated deleted the philip/update-v114 branch October 24, 2023 05:16
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants