Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Document arbitrary-position list spreads #346

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alex-snezhko
Copy link
Member

Ref grain-lang/grain#1665 documenting and warning about performance implications of arbitrary-position spread

@netlify
Copy link

netlify bot commented Feb 11, 2023

Deploy preview ready! 🌾

Name Link
🔨 Latest commit ead99e1
🔍 Latest deploy log https://app.netlify.com/sites/grain-lang/deploys/63e7dc55d9ad3300087c4ea2
😎 Deploy Preview https://deploy-preview-346--grain-lang.netlify.app/docs/guide/lists
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/guide/lists.md Outdated Show resolved Hide resolved
src/guide/lists.md Outdated Show resolved Hide resolved
@alex-snezhko
Copy link
Member Author

How does this new wording look?

Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Have some suggested wording, but I think this looks great.

src/guide/lists.md Outdated Show resolved Hide resolved
src/guide/lists.md Show resolved Hide resolved
@@ -25,6 +25,22 @@ print(oneTwoThree) // [1, 2, 3]

We can also write functions that process data in lists, but we'll save that fun for the section on Pattern Matching.

## More On Spreads (`...`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## More On Spreads (`...`)
## More on Spreads (`...`)

@ospencer
Copy link
Member

Blocked on grain-lang/grain#1665

@alex-snezhko Can we mark this as a draft for now?

@alex-snezhko alex-snezhko marked this pull request as draft March 29, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants