Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include upload maxFileSize and maxRequestSize. #492

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

rpalcolea
Copy link
Contributor

@rpalcolea rpalcolea commented Sep 12, 2016

Hi @graemerocher and @jeffbrown

This is related to #489

Includes upload maxFileSize and maxRequestSize documentation

As suggested by Graeme in #491 (comment) I opened a pull request to add this to the 3.0.x branch and make this change available for Grails 3.x

@graemerocher graemerocher merged commit 28bde0b into grails:3.0.x Sep 12, 2016
@rpalcolea rpalcolea deleted the issue-489/upload-fileSize branch September 12, 2016 15:00
@rpalcolea
Copy link
Contributor Author

rpalcolea commented Sep 12, 2016

Thanks for the merge @graemerocher

Do you consider necessary an update to http://docs.grails.org/latest/guide/contributing.html#patchesDoc explaining the way branching model works for future contributions?

I was reading 'Submit Patches to Grails Core' and it suggests to always keep up to date with master. I assumed the same thing for the docs. (I know, it doesn't make sense since the docs on master are for the latest release).

Perhaps adding an explanation that you should open the patch to the branch that corresponds to the release(s) you want to update. For example

  • branch 3.0.x -> Grails 3.x+
  • branch 3.1.x -> Grails 3.1+
  • branch master -> Grails 3.2+

your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants