#13552 Converters repo merge #13963

jdaugherty · 2025-01-09T15:24:35Z

Merges the converters repo back into core. Will open a separate ticket to remove the deprecated functionality. The main reason for this merge is to continue to support as JSON , etc since so many grails plugins & projects still use these technique.

…ries"

…ents when creating new data with a POST"

…XML elements when creating new data with a POST"

…ents when creating new data with a POST"

…aller (from JSON)"

…app/domain class with @grails.persistence.Entity. We may need to take a more holistic look at the general problem. This commit addresses a specific problematic scenario and adds some relevant tests.

…and defaults for jar names.

We need to revisit these changes as they have created problems for the build. Some artifacts would have the wrong name. For example, these changes caused grails-resources/build/libs/grails-resources-shared-files.jar to be created instead of grails-resources/build/libs/grails-shared-files.jar. This reverts commits e2b8ae2 and e0a373d.

enum.values() is an array of the enum type and Grails was doing the conversion by invoking DefaultGroovyMethods.asType(delegate, clazz) from ConverterUtil. ConverterUtil is written in Java so that call is going to asType(Object, Class) when we really want it to go to asType(Object[], Class).

The code was attempting to parse the request even if it was empty.

…s failing in Grails 2" - Make sure ValiationErrors is always used instead of BeanPropertyBindingResult - Restore mocking of errors property access - Improve error message when a domain is not correctly mocked

The code was attempting to parse the request even if it was empty.

…ng Groovy "as" operator"

…ng Groovy "as" operator" Conflicts: grails-plugin-converters/src/test/groovy/org/codehaus/groovy/grails/web/converters/ConverterUtilSpec.groovy

Removing the "fix" but leaving the tests in place. Since the resolution of GROOVY-5210 I don't think our fix is necessary.

This problem was fixed when in Groovy 1.8.5 when GROOVY-5210 was resolved.

…able to run on the build server

Conflicts: grails-bootstrap/src/test/groovy/org/codehaus/groovy/grails/resolve/PluginResolveEngineSpec.groovy

… the same as Domain classes found in domain folder"

…d relying on Gradle to do the right thing

- Update to Grails 7 - Java 17 - Groovy 4 - Jakarta Servlet - ci: Update the Github workflows - build: Add javaparse dependency to groovydoc task

….1.12

* Revert "fix: Remove dependency on SpringIOUtils" This reverts commit 02f5258 * chore(cleanup): Cleanup and modernize `XML.java`

* build: Use java toolchain and test suite See: https://docs.gradle.org/8.10/userguide/upgrading_version_8.html#test_framework_implementation_dependencies * build: Migrate from `gradleEnterprise` to `develocity` 3.18 This commit updates the build configuration to replace the deprecated gradleEnterprise extension with the new develocity extension (version 3.18). This migration ensures compatibility with future updates and takes advantage of the latest features and improvements in the develocity plugin.

fix(deps): update dependency org.springframework:spring-context to v6.1.12

* Update dependencies to resolve build issue

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

CLAassistant · 2025-01-09T15:24:50Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 10 committers have signed the CLA.

✅ davydotcom
✅ puneetbehl
✅ jamesfredley
✅ jdaugherty
✅ guillermocalvo
✅ matrei
❌ graemerocher
❌ bobbywarner
❌ aulea
❌ humberthardy
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

grails-plugin-converters/build.gradle

grails-plugin-converters/grails-app/init/org/grails/plugins/converters/Application.groovy

grails-plugin-converters/build.gradle

gradle.properties

grails-plugin-converters/build.gradle

bobbywarner and others added 30 commits June 14, 2011 08:55

GRAILS-7071 Fix - JSON DateMarshaller

e3ea493

fix for GRAILS-6787 "XML converter cannot handle arrays with null ent…

003ecf4

…ries"

fix for GRAILS-6981 "REST: parseRequest doesn't parse nested XML elem…

582e995

…ents when creating new data with a POST"

Another fix for GRAILS-6981 "REST: parseRequest doesn't parse nested …

0e03310

…XML elements when creating new data with a POST"

fix for GRAILS-6981 "REST: parseRequest doesn't parse nested XML elem…

fbc4f61

…ents when creating new data with a POST"

whitespace/cleanup

decadd0

fix for GRAILS-7277 "Copy/Paste error in XML InstanceMethodBasedMarsh…

61c48e7

…aller (from JSON)"

GRAILS-7850 - Fix compilation errors resulting from marking a grails-…

bf80bb8

…app/domain class with @grails.persistence.Entity. We may need to take a more holistic look at the general problem. This commit addresses a specific problematic scenario and adds some relevant tests.

whitespace, STS warnings, etc.

1080164

Simplify build by using defaults for archivesBaseName “project name” …

309b64b

…and defaults for jar names.

whitespace, STS warnings, cleanup

e1edf35

GRAILS-4685 - XML converter should base64 encode byte arrays

7cc173e

GRAILS-5997 - Improve JSON request parsing

abffc1b

The code was attempting to parse the request even if it was empty.

Various fixes for GRAILS-8708 "Old-style 1.3.x domain class unit test…

339ef59

…s failing in Grails 2" - Make sure ValiationErrors is always used instead of BeanPropertyBindingResult - Restore mocking of errors property access - Improve error message when a domain is not correctly mocked

Merge branch 'master' of github.com:grails/grails-core

8d059a6

Various fixes for GRAILS-8708 "Old-style 1.3.x domain class unit test…

129dcef

…s failing in Grails 2" - Make sure ValiationErrors is always used instead of BeanPropertyBindingResult - Restore mocking of errors property access - Improve error message when a domain is not correctly mocked

GRAILS-5997 - Improve JSON request parsing

bf7cdfa

The code was attempting to parse the request even if it was empty.

fix for GRAILS-8800 "GroovyCastException thrown when casting null usi…

3e7e0aa

…ng Groovy "as" operator"

fix for GRAILS-8800 "GroovyCastException thrown when casting null usi…

eb7fe31

…ng Groovy "as" operator" Conflicts: grails-plugin-converters/src/test/groovy/org/codehaus/groovy/grails/web/converters/ConverterUtilSpec.groovy

GRAILS-8273 - "as" causes InstantiationException

65610a0

Removing the "fix" but leaving the tests in place. Since the resolution of GROOVY-5210 I don't think our fix is necessary.

GRAILS-8273 - Fix "enum.values() as Set"

ef9572e

This problem was fixed when in Groovy 1.8.5 when GROOVY-5210 was resolved.

ignoring test temporarily, as due to infrastructure issues it is not …

64adb26

…able to run on the build server

Merge branch '2.1.x' of github.com:grails/grails-core into 2.1.x

420a36b

Conflicts: grails-bootstrap/src/test/groovy/org/codehaus/groovy/grails/resolve/PluginResolveEngineSpec.groovy

whitespace, cleanup, STS warnings

e1555b7

fix for GRAILS-9513 "Hibernate Mapping Domain classes are not treated…

a93fc26

… the same as Domain classes found in domain folder"

syncing 2.0.x

4e84cac

Merge branch '2.1.x' into 2.2.x

bc14c02

fix broken create-app by not using archiveBaseName or jar.appendix an…

0c0d2d1

…d relying on Gradle to do the right thing

guillermocalvo and others added 19 commits April 15, 2024 11:10

chore(build): Migrate to Develocity build cache connector (grails#41)

50b5642

chore: Next development version 6.0.0-SNAPSHOT

756c60b

feat!: Update to Grails 7 (grails#56)

226514f

- Update to Grails 7 - Java 17 - Groovy 4 - Jakarta Servlet - ci: Update the Github workflows - build: Add javaparse dependency to groovydoc task

fix(deps): update dependency org.springframework:spring-context to v6…

c069645

….1.12

Revert SpringIOUtils removal (grails#60)

7d5a3ef

* Revert "fix: Remove dependency on SpringIOUtils" This reverts commit 02f5258 * chore(cleanup): Cleanup and modernize `XML.java`

Cleanup Build Warnings and Upgrade to Gradle 8.10 (grails#62)

0706606

Merge pull request grails#36 from grails/renovate/spring-core

12c1815

fix(deps): update dependency org.springframework:spring-context to v6.1.12

Update dependencies to resolve build issue (grails#69)

dc4c5ab

* Update dependencies to resolve build issue

chore(deps): update dependency gradle to v8.10.2 (grails#66)

12bad6a

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update converters for pre release workflow

00dd478

Add maven variable

fe7addc

Convert to grails github action

569724f

[skip ci] Release v6.0.0-M1

2c2b443

add github token to post release workflow

7323511

Back to snapshot

a5358be

Imported grails/grails-plugin-converters

31cf052

Integrate converters project

16b04f6

Merge branch '7.0.x' into convertersRepoMerge

a4f94dd

jdaugherty requested review from matrei and jamesfredley January 9, 2025 15:25

jdaugherty mentioned this pull request Jan 9, 2025

Restructure Grails-Core repository #13552

Open

jdaugherty changed the title ~~Converters repo merge~~ #13552 Converters repo merge Jan 9, 2025

Merge branch '7.0.x' into convertersRepoMerge

7488665

jamesfredley approved these changes Jan 9, 2025

View reviewed changes

matrei requested changes Jan 9, 2025

View reviewed changes

Code Review feedback from converters merge

df0ddc7

matrei approved these changes Jan 9, 2025

View reviewed changes

jdaugherty merged commit 162eba5 into grails:7.0.x Jan 9, 2025
19 of 20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#13552 Converters repo merge #13963

#13552 Converters repo merge #13963

jdaugherty commented Jan 9, 2025

CLAassistant commented Jan 9, 2025 •

edited

Loading

#13552 Converters repo merge #13963

#13552 Converters repo merge #13963

Conversation

jdaugherty commented Jan 9, 2025

CLAassistant commented Jan 9, 2025 • edited Loading

CLAassistant commented Jan 9, 2025 •

edited

Loading