Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13655 - restore dot notation navigation #13869

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

jdaugherty
Copy link
Contributor

No description provided.

@codeconsole
Copy link
Contributor

codeconsole commented Nov 22, 2024

@jdaugherty why were all those public access modifiers there previously? Was it a Java class that got converted to Groovy?

@jdaugherty
Copy link
Contributor Author

@jdaugherty why were all those public access modifiers there previously? Was it a Java class that got converted to Groovy?

That was my assumption, btw: this is still a draft pull request. I need to make sure the functional tests are passing before I can activate this.

@codeconsole
Copy link
Contributor

@jdaugherty why were all those public access modifiers there previously? Was it a Java class that got converted to Groovy?

That was my assumption, btw: this is still a draft pull request. I need to make sure the functional tests are passing before I can activate this.

if that is the case, is going back to Java an option since this class is used so much?

@jdaugherty
Copy link
Contributor Author

@jdaugherty why were all those public access modifiers there previously? Was it a Java class that got converted to Groovy?

That was my assumption, btw: this is still a draft pull request. I need to make sure the functional tests are passing before I can activate this.

if that is the case, is going back to Java an option since this class is used so much?

I'll look into it.

@jdaugherty jdaugherty force-pushed the feature/7.0.0/13655-dot-notation branch from def80d0 to b92fc87 Compare November 22, 2024 22:48
@@ -488,4 +489,172 @@ class NavigableMap implements Map<String, Object>, Cloneable {
boolean equals(Object obj) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulk-asert This class is tagged with both @EqualsAndHashCode and it then implements it's own equals / hashcode. Do you know if the groovy transformation will have any effect?

@jdaugherty jdaugherty marked this pull request as ready for review December 11, 2024 13:39
@jdaugherty
Copy link
Contributor Author

I went ahead and marked this for review so we can restore this function for the milestone. I'll work on the java conversion separately from this PR and will leave the ticket open.

@jdaugherty jdaugherty merged commit ef551a2 into grails:7.0.x Dec 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grails 7: Accessing config key 'grails.sitemesh.default.layout' through dot notation is deprecated
4 participants