Align versions of transitive dependencies with Grails specified versions #13860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-orm` Ensure consistent versions of `spring-core`, `spring-jcl`, and `spring-orm` across all transitive dependencies. This resolves potential version conflicts caused by different versions being pulled in by other dependencies. Close #13856
Ensure consistent version of `snakeyaml` across all transitive dependencies. This resolves potential version conflicts caused by different versions being pulled in by other dependencies.
Ensure consistent version of `tomcat-jdbc` and `tomcat-juli` across all transitive dependencies. This resolves potential version conflicts caused by different versions being pulled in by other dependencies.
matrei
force-pushed
the
matrei/align-versions
branch
from
d2716d6 to
f86be45
Compare
jdaugherty
approved these changes
Nov 19, 2024
| } | ||
| /* | ||
| if (details.requested.group == 'org.yaml' && details.requested.name == 'snakeyaml') { | ||
| details.useVersion(snakeyamlVersion) |
There was a problem hiding this comment.
Shouldn't we remove snakeyaml since it is commented out?
There was a problem hiding this comment.
Oops! I was testing something and missed to enable this again. I am unsure about snakeyaml. 2.0 is pulled in by other libraries. Will it work to force 2.2?
|
Can you confirm this won't be merged up into 7.0.x? This shouldn't be needed with the 7.x bom |
jamesfredley
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13856