-
-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bom #13755
Fix Bom #13755
Conversation
build.gradle
Outdated
group : 'org.grails', | ||
names : ['grails-gradle-plugin'], | ||
modules: [''] | ||
], | ||
'fieldsPlugin' : [version: fieldsPluginVersion, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also move the fields
plugin to plugins.properties
? fields
was probably added here because it was using group io.github.gpc
at the time of inclusion. Now that fields
is using org.grails.plugins
we can delete it here and add fields=6.0.0-SNAPSHOT
to plugins.properties
instead. Then we should also be able to remove fieldsPluginVersion=6.0.0-SNAPSHOT
from gradle.properties
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea!
@matrei I see you approved it, let's see if this thing works. lol |
@@ -1,12 +1,12 @@ | |||
cache=8.0.0-SNAPSHOT | |||
fieldsPluginVersion=6.0.0-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the property must be fields=6.0.0-SNAPSHOT
as the artifactId is taken from the property name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! You shouldn't have pre-approved lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what happens when I copy and paste while talking to 3 people at the same time. 🤦
copy and paste fix |
Tested with
|
@jamesfredley thanks for verifying 😄 |
Makes grails-gradle-plugin a dependency and not a plugin
Removes exclusions no longer needed due to the dependencies should not have been dependencies in the first place.