Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sitemesh. Buffering is triggered on response.setContentType so rendering needs to be done on wrapped response. #13714

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix for sitemesh. Buffering is triggered on response.setContentType so rendering needs to be done on wrapped response. #13714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions grails-web-common/src/main/groovy/org/grails/web/servlet/view/AbstractGrailsView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;

import org.grails.web.servlet.WrappedResponseHolder;
import org.grails.web.util.GrailsApplicationAttributes;
import org.grails.web.servlet.mvc.GrailsWebRequest;
import org.grails.web.util.WebUtils;
Expand Down Expand Up @@ -68,6 +69,8 @@ private void renderWithinGrailsWebRequest(Map<String, Object> model, HttpServlet
} else {
webRequest = (GrailsWebRequest)requestAttributes;
}
// Update response holder to latest response. Necessary for sitemesh to trigger buffering.
WrappedResponseHolder.setWrappedResponse(response);
renderTemplate(model, webRequest, request, response);
} finally {
if(attributesChanged) {
Expand Down
Loading