Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Micronaut Parent Context #13685

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

codeconsole
Copy link
Contributor

@codeconsole codeconsole commented Sep 25, 2024

Requires grails/grails-testing-support#421 for tests to work

@davydotcom davydotcom merged commit eb0ad65 into grails:7.0.x Sep 25, 2024
9 of 11 checks passed
@matrei
Copy link
Contributor

matrei commented Sep 26, 2024

Hmm..., was this PR ready to be merged?

@davydotcom
Copy link
Contributor

yes

@matrei
Copy link
Contributor

matrei commented Sep 26, 2024

😄 It's breaking the test suite, so now we can't do any other changes and rely on the tests

@jamesfredley
Copy link
Contributor

After the merge and grails/grails-testing-support#421 (review) being addressed, it revealed a number of currently failing tests on grails-core. Here are some of the higher priority failures.

DataBindingConfigurationSpec
[Test worker] ERROR grails.plugins.DefaultGrailsPluginManager - ERROR: Plugin [domainClass] cannot be loaded because its dependencies [['i18n']] cannot be resolved
[Test worker] ERROR grails.plugins.DefaultGrailsPluginManager - ERROR: Plugin [converters] cannot be loaded because its dependencies [['controllers', 'domainClass']] cannot be resolved
[Test worker] ERROR grails.plugins.DefaultGrailsPluginManager - ERROR: Plugin [mimeTypes] cannot be loaded because its dependencies [['core', 'controllers']] cannot be resolved

RespondMethodSpec
[Test worker] WARN org.grails.datastore.mapping.core.DatastoreUtils - Cannot unbind session, there's no SessionHolder registered

GrailsWebDataBinderConfigurationSpec
No signature of method: org.grails.spring.context.support.PluginAwareResourceBundleMessageSource.addMessage() is applicable for argument types: (String, Locale, String) values: [my.date.format, en_US, MMddyyyy]

GrailsUnitTestMixinGrailsApplicationAwareSpec
java.lang.NullPointerException: Cannot get property 'grailsApplication' on null object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating to latest version of Micronaut or remove the Micronaut Integration
4 participants