Decouple grails-plugin-controllers from Sitemesh

[codeconsole]

Fixes #13623 - These changes make controllers independent of Sitemesh

Moved these attributes from ResponseRenderer.groovy

    static final String LAYOUT_ATTRIBUTE = "org.grails.layout.name";
    static final String NONE_LAYOUT = "_none_";

to ControllersGrailsPlugin.groovy

Any recommendations for a different location?

[matrei]

How about creating a org.grails.plugins.web.controllers.SitemeshConstants class to encapsulate these values. This approach makes their context more explicit when used throughout the codebase.

[codeconsole]

How about creating a org.grails.plugins.web.controllers.SitemeshConstants class to encapsulate these values. This approach makes their context more explicit when used throughout the codebase.

It’s only 2 properties. I was hoping for a more general location outside of the controllers plugin that has definitions for other things. If it is going to live under controllers, it can stay in the plugin definition class

[jamesfredley]

I think it's OK in the plugin controller. There were not many great locations outside of the controller plugin. This was about the best I saw looking through 30-40 with constants.

grails-core/grails-web-common/src/main/groovy/grails/util/GrailsWebUtil.java

Lines 46 to 48 in 272f48e

	public static final String DEFAULT_ENCODING = "UTF-8";
	private static final String CHARSET_ATTRIBUTE = ";charset=";
	private static final Pattern CHARSET_IN_CONTENT_TYPE_REGEXP = Pattern.compile(";\\s*charset\\s*=", Pattern.CASE_INSENSITIVE);

[codeconsole]

I think it's OK in the plugin controller. There were not many great locations outside of the controller plugin. This was about the best I saw looking through 30-40 with constants.

grails-core/grails-web-common/src/main/groovy/grails/util/GrailsWebUtil.java

Lines 46 to 48 in 272f48e

	public static final String DEFAULT_ENCODING = "UTF-8";
	private static final String CHARSET_ATTRIBUTE = ";charset=";
	private static final Pattern CHARSET_IN_CONTENT_TYPE_REGEXP = Pattern.compile(";\\s*charset\\s*=", Pattern.CASE_INSENSITIVE);

looks like those constants are only used in that class.

[codeconsole]

Since grails-web-sitemesh this is causing issues further down the line. I am going to merge it. We can always move it later.

[matrei]

Thats fine, I just wonder if we then could name them SITEMESH_LAYOUT_ATTRIBUTE and SITEMESH_LAYOUT_NONE?

[matrei]

The org.grails.plugins.web.controllers.metaclass.RenderDynamicMethods class looks like a candidate to hold these values.

[codeconsole]

RenderDynamicMethods

Are all those constants related?

[codeconsole]

Thats fine, I just wonder if we then could name them SITEMESH_LAYOUT_ATTRIBUTE and SITEMESH_LAYOUT_NONE?

yeah, that would make sense after we confirm final location for them.

[codeconsole]

ok, so this rabbit hole just got a little deeper. It looks like this variable was also defined in another location. I found the new home. WebUtils.java

[codeconsole]

#13626