Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply license gradle plugin #13535

Merged
merged 15 commits into from
Aug 20, 2024
Merged

apply license gradle plugin #13535

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
bb5ff09
chore(ci): Update renovate.json (#13488)
puneetbehl Apr 30, 2024
04b52f2
fix(deps): update apache-tomcat monorepo to v9.0.88 (#13500)
renovate[bot] May 2, 2024
92bba69
fix(deps): update dependency com.github.javaparser:javaparser-core to…
renovate[bot] May 3, 2024
26245fe
fix(deps): update grails-testing-support monorepo to v3.2.2 (#13504)
renovate[bot] May 3, 2024
434b370
apply license gradle plugin
sdelamo Jul 4, 2024
9e7b153
extract to gradle/dependency-licenses.gradle
sdelamo Jul 17, 2024
a40b53a
Update build.gradle
sdelamo Jul 19, 2024
d721bd9
Update gradle.properties
sdelamo Jul 19, 2024
76e5195
Update gradle.properties
sdelamo Jul 19, 2024
b489a73
Update renovate.json
sdelamo Jul 19, 2024
494dd22
fix merge
sdelamo Jul 19, 2024
22be4aa
Merge branch '7.0.x' into licenses-plugin
sdelamo Jul 19, 2024
150c67c
Merge branch '7.0.x' into licenses-plugin
sdelamo Jul 19, 2024
0bb3d90
apply licenses.gradle in allProjects
sdelamo Jul 19, 2024
9a8826a
simplify licenseExclusions
sdelamo Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ buildscript {
classpath "javax.xml.bind:jaxb-api:$jaxbApiVersion"
classpath "com.sun.xml.bind:jaxb-impl:$jaxbImplVersion"
classpath "org.codehaus.groovy.modules.http-builder:http-builder:0.7.2"
classpath("gradle.plugin.com.hierynomus.gradle.plugins:license-gradle-plugin:0.16.1")
}
}

Expand Down Expand Up @@ -298,6 +299,7 @@ allprojects {
}

apply from: "gradle/idea.gradle"
apply from: "gradle/dependency-licenses.gradle"
matrei marked this conversation as resolved.
Show resolved Hide resolved

subprojects { project ->

Expand Down Expand Up @@ -340,6 +342,7 @@ subprojects { project ->
apply plugin: 'eclipse'
apply plugin: 'idea'
apply plugin: 'project-report'
apply from: "../gradle/dependency-licenses.gradle"

if (!isTestSuite) {

Expand Down
46 changes: 46 additions & 0 deletions gradle/dependency-licenses.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
apply plugin: 'com.github.hierynomus.license-report'

List<String> licenseExclusions = [
"org.grails.grails-bom",
"org.grails:grails-bootstrap",
"org.grails:grails-codecs",
"org.grails:grails-console",
"org.grails:grails-core",
"org.grails:grails-databinding",
"org.grails:grails-dependencies",
"org.grails:grails-docs",
"org.grails:grails-encoder",
"org.grails:grails-gradle-model",
"org.grails:grails-logging",
"org.grails:grails-plugin-codecs",
"org.grails:grails-plugin-controllers",
"org.grails:grails-plugin-databinding",
"org.grails:grails-plugin-datasource",
"org.grails:grails-plugin-domain-class",
"org.grails:grails-plugin-i18n",
"org.grails:grails-plugin-interceptors",
"org.grails:grails-plugin-mimetypes",
"org.grails:grails-plugin-rest",
"org.grails:grails-plugin-services",
"org.grails:grails-plugin-url-mappings",
"org.grails:grails-plugin-validation",
"org.grails:grails-spring",
"org.grails:grails-test",
"org.grails:grails-test-suite-base",
"org.grails:grails-test-suite-persistence",
"org.grails:grails-test-suite-uber",
"org.grails:grails-test-suite-web",
"org.grails:grails-web",
"org.grails:grails-web-boot",
"org.grails:grails-web-common",
"org.grails:grails-web-databinding",
"org.grails:grails-web-fileupload",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and org.grails:grails-web-fileupload is removed in 7.0.x.

If all we want is to exclude all the subprojects, could we do this instead to not have to maintain the list:

// We don't want to include any of the libraries from this repo in the license report
List<String> licenseExclusions = rootProject.subprojects.collect {
    "org.grails:${it.name}:${rootProject.projectVersion}" as String
}

and we probably want to be able to verify the list:

tasks.register('printLicenseExclusions') {
    group = 'license'
    description = 'Prints the license exclusions list'
    doLast {
        println """
            |============================================================
            |The following projects are excluded from the license report:
            |============================================================
            |${licenseExclusions.join('\n')}
        """.stripMargin()
    }
}

"org.grails:grails-web-mvc",
"org.grails:grails-web-url-mappings",
].collect { "${it}:${project.projectVersion}" as String}

downloadLicenses {
includeProjectDependencies = true
dependencyConfiguration = 'runtimeClasspath'
excludeDependencies = licenseExclusions
}
Loading