Make grails-web-sitemesh optional due to GroovyPageLayoutFinder being required by ResponseRenderer trait. #13165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately GroovyPageLayoutFinder is coupled to ResponseRenderer
and because it is a trait, changing it in any way would break any controller in a previously compiled plugin.
So basically, we are stuck with this dependency which will be resolved if either the grails sitemesh 2 or sitemesh 3 plugin is installed. Sitemesh 2 was made a transitive dependency of the
org.grails.plugins:gsp
because the plugin is responsible for configuringGroovyPageLayoutFinder
.This pull request makes all
grails-web-sitemesh
dependencies optional since they will be resolved byorg.grails.plugins:gsp