Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grails-web-sitemesh optional due to GroovyPageLayoutFinder being required by ResponseRenderer trait. #13165

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

codeconsole
Copy link
Contributor

Unfortunately GroovyPageLayoutFinder is coupled to ResponseRenderer

and because it is a trait, changing it in any way would break any controller in a previously compiled plugin.

So basically, we are stuck with this dependency which will be resolved if either the grails sitemesh 2 or sitemesh 3 plugin is installed. Sitemesh 2 was made a transitive dependency of the org.grails.plugins:gsp because the plugin is responsible for configuring GroovyPageLayoutFinder.

This pull request makes all grails-web-sitemesh dependencies optional since they will be resolved by org.grails.plugins:gsp

@codeconsole codeconsole mentioned this pull request Oct 13, 2023
1 task
@puneetbehl puneetbehl merged commit 943d32e into grails:6.0.x Oct 15, 2023
@codeconsole
Copy link
Contributor Author

@puneetbehl I will take a look.
the tests fail because org/grails/web/sitemesh/GroovyPageLayoutFinder is not in the class path. This is what was happening before with the other tests.

GroovyPageLayoutFinder is part of grails-web-sitemesh which is a transitive dependency of grails:plugins:gsp which is what injects groovyPageLayoutFinder. I believe it is the RestRederer trait that is causing the issue. I have just been adding grails-web-sitemesh as a test dependecy because the assumption is that grails-web-sitemesh will resolve automatically due to any grails app needing the grails:plugins:gsp dependency. Is there a situation you know of where a specific type of grails app will not have the grails:plugins:gsp plugin installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants