Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution Fails to Run #13760

Closed
matrei opened this issue Oct 16, 2024 · 7 comments · Fixed by #13948
Closed

Distribution Fails to Run #13760

matrei opened this issue Oct 16, 2024 · 7 comments · Fixed by #13948

Comments

@matrei
Copy link
Contributor

matrei commented Oct 16, 2024

Expected Behavior

.\gradlew assemble
unzip .\build\distribrutions\grails-7.0.0-SNAPSHOT.zip
.\build\distributions\grails-7.0.0-SNAPSHOT\bin\grails -version
| Grails Version: 7.0.0-SNAPSHOT
| JVM Version: 17.0.12

Actual Behaviour

.\gradlew assemble
unzip .\build\distribrutions\grails-7.0.0-SNAPSHOT.zip
.\build\distributions\grails-7.0.0-SNAPSHOT\bin\grails -version

Exception: java.lang.NoSuchMethodError thrown from the UncaughtExceptionHandler in thread "main"

Steps To Reproduce

No response

Environment Information

  • Operating system: Windows 11
  • JDK Version: OpenJDK 64-Bit Server VM Temurin-17.0.12+7 (build 17.0.12+7, mixed mode, sharing)

Example Application

No response

Version

7.0.0-SNAPSHOT

@matrei matrei added this to Grails 7 Oct 16, 2024
@matrei matrei moved this to Todo in Grails 7 Oct 16, 2024
@jamesfredley
Copy link
Contributor

more details: #13740 (comment)

@jamesfredley
Copy link
Contributor

This may have been resolved by #13801, but testing it is blocked by #13816

@jamesfredley
Copy link
Contributor

#13816 and #13801 got us past the initial issues.

now need to have org.gradle:gradle-tooling-api in the distribution

grails
Error: Unable to initialize main class org.grails.cli.GrailsCli
Caused by: java.lang.NoClassDefFoundError: org/gradle/tooling/BuildCancelledException

https://github.com/grails/grails-core/pull/13762/files set it to compileOnly so that the extra gradle repo was not needed in every project.

@matrei matrei changed the title Distribution fails to run on Windows Distribution Fails to Run Dec 2, 2024
matrei added a commit that referenced this issue Dec 12, 2024
@jamesfredley
Copy link
Contributor

#13919 gets us past Unable to initialize main class org.grails.cli.GrailsCli

@jamesfredley
Copy link
Contributor

jamesfredley commented Dec 14, 2024

#13919 (comment)

But when running grails it chokes on another problem:

$ ./grails-7.0.0-SNAPSHOT/bin/grails --stacktrace
| Error Error occurred running Grails CLI: Could not find artifact org.grails.profiles:angular:jar:${profiles-angular.version} in grailsCentral (https://repo.grails.org/grails/core) (NOTE: Stack trace has been filtered. Use --verbose to see entire trace.)
org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.grails.profiles:angular:jar:${profiles-angular.version} in grailsCentral (https://repo.grails.org/grails/core)
        at org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:42)
        at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417)
        at org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260)
        at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:537)
        at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:449)
        at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:261)
        at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:353)
        at org.grails.cli.compiler.grape.MavenResolverGrapeEngine.resolve(MavenResolverGrapeEngine.java:292)
        at org.grails.cli.compiler.grape.MavenResolverGrapeEngine.grab(MavenResolverGrapeEngine.java:115)
        at org.grails.cli.compiler.grape.MavenResolverGrapeEngine.grab(MavenResolverGrapeEngine.java:107)
        at org.grails.cli.profile.repository.MavenProfileRepository.getAllProfiles(MavenProfileRepository.groovy:135)
        at org.grails.cli.GrailsCli.execute(GrailsCli.groovy:240)
        at org.grails.cli.GrailsCli.main(GrailsCli.groovy:160)
| Error Error occurred running Grails CLI: Could not find artifact org.grails.profiles:angular:jar:${profiles-angular.version} in grailsCentral (https://repo.grails.org/grails/core)

It seems the bom version variables are not resolved.

@codeconsole
Copy link
Contributor

@jamesfredley is it how it is trying to resolve it? Should it use something similar to this since it is not camelCase?

${project['profiles-angular.version']}"

@jamesfredley
Copy link
Contributor

https://repo.grails.org/ui/repos/tree/PomView/libs-snapshots-local/org/grails/grails-bom/7.0.0-SNAPSHOT/grails-bom-7.0.0-20241229.020850-191.pom

${profiles-angular.version} was coming from grails-bom and org.grails.cli.boot.GrailsDependencyVersions needed to be updated to handle version lookup

<properties>
     <profiles-angular.version>10.0.1</profiles-angular.versio>
</properties>
<dependencyManagement>
     <dependencies>
          <dependency>
               <groupId>org.grails.profiles</groupId>
               <artifactId>angular</artifactId>
               <version>${profiles-angular.version}</version>
          </dependency>
     </dependencies>
</dependencyManagement>

@jamesfredley jamesfredley linked a pull request Dec 31, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Todo to Done in Grails 7 Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants