Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies, skip failing tests and re-enable tests on workflows #907

Merged
merged 6 commits into from
Oct 19, 2024
Merged

Update dependencies, skip failing tests and re-enable tests on workflows #907

merged 6 commits into from
Oct 19, 2024

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Oct 18, 2024 •
edited
Loading

image

Long list of failing, skipped tests: #879

matrei
matrei previously requested changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we remove mavenLocal() from the root build.gradle file.
  • The tests are currently not enabled in .github/workflows/gradle.yml

@jamesfredley jamesfredley requested a review from matrei October 19, 2024 13:42
@jamesfredley jamesfredley dismissed matrei’s stale review October 19, 2024 13:43

mavenLocal() adjusted for use with joint workflow. gradle.yml change pushed.

@jamesfredley jamesfredley merged commit 4914962 into 9.0.x Oct 19, 2024
7 checks passed
@jamesfredley jamesfredley deleted the update-dependencies-fix-skip-tests branch October 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrei matrei matrei approved these changes

@jdaugherty jdaugherty Awaiting requested review from jdaugherty

Assignees
No one assigned
Labels
ci maintenance test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesfredley @matrei @grails-build