Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 4.1.x into 5.0.x #111

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Merge 4.1.x into 5.0.x #111

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9e6945
[skip ci] Release v4.1.0
grails-build Dec 12, 2024
02efb4c
chore: Bump version to 4.1.1-SNAPSHOT
grails-build Dec 12, 2024
3986649
fix setup() methods being called
jdaugherty Dec 17, 2024
b4f35e6
Merge pull request #107 from jdaugherty/4.1.x
jdaugherty Dec 18, 2024
68394d9
fix: add `selenium-support` (#110)
matrei Dec 19, 2024
b44ffb9
Merge branch '4.1.x' into merge-4.1.x-into-5.0.x
matrei Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,16 @@ dependencies {

testFixturesCompileOnly 'jakarta.servlet:jakarta.servlet-api'
testFixturesCompileOnly 'org.slf4j:slf4j-simple' // Remove compilation warning about missing slf4j impl

testFixturesApi 'org.gebish:geb-spock'
testFixturesApi 'org.grails:grails-testing-support'
testFixturesApi 'org.grails:grails-datastore-gorm'
testFixturesApi "org.testcontainers:selenium:$testcontainersVersion"
testFixturesApi "org.seleniumhq.selenium:selenium-chrome-driver:$seleniumVersion"
testFixturesApi "org.seleniumhq.selenium:selenium-remote-driver:$seleniumVersion"

testFixturesImplementation "org.seleniumhq.selenium:selenium-support:$seleniumVersion"

documentation 'org.apache.groovy:groovy'
documentation 'org.apache.groovy:groovy-ant'
documentation 'org.apache.groovy:groovy-templates'
Expand All @@ -65,7 +68,7 @@ grailsPublish {
puneetbehl: 'Puneet Behl',
sbglasius: 'Søren Berg Glasius',
matrei: 'Mattias Reichel',
jdaugherty: 'James Daugherty',
jdaugherty: 'James Daugherty'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you keep the comma it's one left line diff if we ever add someone else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Well, I'd rather have beautiful code 🌷

]
}

Expand Down
Loading