Remove duplicate fragments from resolved request document

[moalazzam]

In scenarios where a fragment is nested and used multiple times, graphql-request includes the fragments' bodies multiple times.

Use case example: Unleash the power of Fragments with GraphQL Codegen

Scenario

const FragmentB = gql`
  fragment FragmentB on Other {
    number
  }
`;

const FragmentA = gql`
  fragment FragmentA on Something {
    value
    other {
      ...FragmentB
    }
  }
  ${FragmentB}
`;

const Query = gql`
  query Query {
    a {
      ...FragmentA
    }
    b {
      ...FragmentB
    }
  }
  ${FragmentA}
  ${FragmentB}
`;

Current output

  query Query {
    a {
      ...FragmentA
    }
    b {
      ...FragmentB
    }
  }

  fragment FragmentA on Something {
    value
    other {
      ...FragmentB
    }
  }

  fragment FragmentB on Other {
    number
  }

  fragment FragmentB on Other {
    number
  }

Pull request output

  query Query {
    a {
      ...FragmentA
    }
    b {
      ...FragmentB
    }
  }

  fragment FragmentA on Something {
    value
    other {
      ...FragmentB
    }
  }

  fragment FragmentB on Other {
    number
  }

[jasonkuhrt]

Thanks @moalazzam !

Was going to say can we add a test please. However, if we can use the graphql library for this instead we don't need tests or new custom logic. I would prefer that. Want to take a crack at that?

[moalazzam]

I have updated the code to use the visit function from the graphql library, waiting for review my changes

[jasonkuhrt]

Going to close this. Feel free to open an issue to motivate a problem with graphql-request. But I don't think this is ready for implementation.