Error out on not setting binarytype to arraybuffer #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
codebien and
olegbespalov
and removed request for
a team
olegbespalov
approved these changes
Apr 24, 2024
codebien
approved these changes
Apr 25, 2024
mstoykov
force-pushed
the
binaryTypeWarning
branch
from
c030ff8 to
00f76a3
Compare
mstoykov
force-pushed
the
binarytypeError
branch
from
e908745 to
0572c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Error out if binarytype was not set to arraybuffer.
Why?
This lets us stabalize this in k6 without finishign #35
Checklist
make lint) and all checks pass.make test) and all tests pass.Related PR(s)/Issue(s)