Minimal working version #3
Conversation
olegbespalov
requested review from
oleiade and
codebien
and removed request for
a team
olegbespalov
force-pushed
the
feat/minimal-working-version
branch
from
0c70256 to
c40a57c
Compare
pkg/opentelemetry/output.go
Outdated
| @@ -36,47 +52,198 @@ func New(p output.Params) (*Output, error) { | |||
|
|
|||
| // Description returns a human-readable description of the output that will be shown in `k6 run` | |||
| func (o *Output) Description() string { | |||
| return "OpenTelemetry: " + o.config.Address | |||
| return "opentelemetry: " + o.config.String() | |||
| } | |||
|
|
|||
| // Stop flushes all remaining metrics and finalizes the test run | |||
| func (o *Output) Stop() error { | |||
There was a problem hiding this comment.
| func (o *Output) Stop() error { | |
| func (o *Output) StopWithTestError() error { |
We should implement StopWithTestError instead of Stop(). Stop should just proxy the request.
There was a problem hiding this comment.
I'm not sure if I'm getting the idea or maybe missing the context; Stop is part of the interface. StopWithTestError is planned to replace Stop ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Good catch then, I'll adjust accordingly 👍
| } | ||
|
|
||
| // Stop flushes all remaining metrics and finalizes the test run | ||
| func (o *Output) Stop() error { | ||
| o.logger.Debug("Stopping...") | ||
| defer o.logger.Debug("Stopped!") | ||
|
|
||
| if err := o.meterProvider.Shutdown(context.Background()); err != nil { |
There was a problem hiding this comment.
Should we consider forcing a timeout here? Or do we rely on the fact that the client will have one?
There was a problem hiding this comment.
I think we could introduce a configuration in a later PRs 👍
olegbespalov
force-pushed
the
feat/minimal-working-version
branch
from
c40a57c to
a477b15
Compare
@codebien If possible, we could make this configurable, so probably both. However, the default behavior should be close to most of the other k6 outputs. |
olegbespalov
force-pushed
the
feat/minimal-working-version
branch
from
a477b15 to
2bc64c6
Compare
It has limited support of metric types (count, gauge, trend(?)). Only gRPC receiver. Limited configuration.
olegbespalov
force-pushed
the
feat/minimal-working-version
branch
from
2bc64c6 to
39d991c
Compare
What?
It's the first minimum working version that actually sends metrics to an OTEl receiver.
It has limited support of metric types (count, gauge, trend(?)). Only gRPC receiver. Limited configuration.
Why?
An iterative approach to reduce the scope of the PRs.
Dependent on #2
Part of #1