Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused NetworkManager.ExtraHTTPHeaders method #1524

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Remove unused NetworkManager.ExtraHTTPHeaders method #1524

merged 1 commit into from
Nov 7, 2024

Conversation

inancgumus
Copy link
Member

What?

Remove the unused NetworkManager.ExtraHTTPHeaders method.

Why?

Unused.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@inancgumus inancgumus self-assigned this Nov 6, 2024
@inancgumus inancgumus requested a review from ankur22 November 6, 2024 21:17
@inancgumus inancgumus mentioned this pull request Nov 6, 2024
Closed
ankur22
ankur22 previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus inancgumus force-pushed the desobekify/keyboard-options branch from 3d8c372 to 170f7eb Compare November 7, 2024 14:44
@inancgumus inancgumus requested a review from a team as a code owner November 7, 2024 14:44
@inancgumus inancgumus requested review from olegbespalov and joanlopez and removed request for a team November 7, 2024 14:44
Base automatically changed from desobekify/keyboard-options to main November 7, 2024 14:44
@inancgumus inancgumus dismissed ankur22’s stale review November 7, 2024 14:44

The base branch was changed.

@inancgumus inancgumus force-pushed the remove/network-manager-extra-http-headers branch from b6806de to 14d6082 Compare November 7, 2024 14:45
@inancgumus inancgumus merged commit dbd050f into main Nov 7, 2024
20 of 22 checks passed
@inancgumus inancgumus deleted the remove/network-manager-extra-http-headers branch November 7, 2024 14:45
@BrewTestBot BrewTestBot mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 left review comments

@olegbespalov olegbespalov Awaiting requested review from olegbespalov olegbespalov is a code owner automatically assigned from grafana/k6-core

@joanlopez joanlopez Awaiting requested review from joanlopez joanlopez is a code owner automatically assigned from grafana/k6-core

Assignees

@inancgumus inancgumus

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22