Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak caused by taskqueue closing before all tasks are executed #1493

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix memory leak caused by taskqueue closing before all tasks are executed #1493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions browser/page_mapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,9 +452,11 @@ func mapPageOn(vu moduleVU, p *common.Page) func(common.PageOnEventName, sobek.C
}
}

ctx := vu.Context()

// Run the the event handler in the task queue to
// ensure that the handler is executed on the event loop.
tq := vu.taskQueueRegistry.get(vu.Context(), p.TargetID())
tq := vu.taskQueueRegistry.get(ctx, p.TargetID())
eventHandler := func(event common.PageOnEvent) {
mapping := pageOnEvent.mapp(vu, event)

Expand All @@ -475,7 +477,10 @@ func mapPageOn(vu moduleVU, p *common.Page) func(common.PageOnEventName, sobek.C
})

if pageOnEvent.wait {
<-done
select {
case <-done:
case <-ctx.Done():
ankur22 marked this conversation as resolved.
Show resolved Hide resolved
}
}
}

Expand Down
Loading