Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline the addition and running of new page.on events #1475

Merged
merged 20 commits into from
Oct 11, 2024
Merged

Streamline the addition and running of new page.on events #1475

merged 20 commits into from
Oct 11, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Oct 9, 2024 •
edited
Loading

What?

Generalize page.on events.

Why?

To streamline the addition and running of additional page.on events.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates: #1227

@inancgumus inancgumus added refactor dx developer experience labels Oct 9, 2024
@inancgumus inancgumus self-assigned this Oct 9, 2024
@inancgumus inancgumus mentioned this pull request Oct 10, 2024
Closed
Base automatically changed from refactor/page-on-event to main October 10, 2024 15:32
@inancgumus inancgumus changed the title Generalize the running of page.on events in the task queue Streamline the addition and running of new page.on event types Oct 10, 2024
@inancgumus inancgumus changed the title Streamline the addition and running of new page.on event types Streamline the addition and running of new page.on events Oct 10, 2024
@inancgumus inancgumus force-pushed the refactor/page-on-task-in-queue branch from 95f19c9 to 35c394e Compare October 10, 2024 19:34
@inancgumus inancgumus changed the base branch from main to refactor/page-on-mapping-namings October 10, 2024 19:41
@inancgumus inancgumus force-pushed the refactor/page-on-task-in-queue branch from f3e7693 to 503c4dd Compare October 10, 2024 19:45
@inancgumus inancgumus marked this pull request as ready for review October 10, 2024 19:47
ankur22
ankur22 previously approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! I like the solution a lot.

I've added suggestions, which are mainly nit picks tbh.

browser/page_mapping.go Outdated Show resolved Hide resolved
browser/page_mapping.go Outdated Show resolved Hide resolved
browser/page_mapping.go Outdated Show resolved Hide resolved
browser/page_mapping.go Outdated Show resolved Hide resolved
browser/page_mapping.go Outdated Show resolved Hide resolved
browser/page_mapping.go Outdated Show resolved Hide resolved
browser/page_mapping.go Outdated Show resolved Hide resolved
browser/page_mapping.go Outdated Show resolved Hide resolved
Base automatically changed from refactor/page-on-mapping-namings to main October 11, 2024 13:16
@inancgumus inancgumus dismissed ankur22’s stale review October 11, 2024 13:16

The base branch was changed.

@inancgumus inancgumus force-pushed the refactor/page-on-task-in-queue branch from 7272ab4 to 3c90197 Compare October 11, 2024 13:39
@inancgumus inancgumus merged commit f757283 into main Oct 11, 2024
23 checks passed
@inancgumus inancgumus deleted the refactor/page-on-task-in-queue branch October 11, 2024 19:02
@BrewTestBot BrewTestBot mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 Awaiting requested review from ankur22

Assignees

@inancgumus inancgumus

Labels
dx developer experience refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22