Fix taskqueue not closing when the iteration is aborted #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
approved these changes
Oct 1, 2024
ankur22
force-pushed
the
fix/page-on-deadlock
branch
from
41984a4
to
2a3c171
Compare
This fix ensures that the taskqueue is closed when the iteration ends. If the taskqueue isn't closed when the iteration ends the k6 process will hang indefinitely. We used to rely on page.close, but now that the life cycle of the iteration is controlled by the VU we can safely rely on the VU context to ensure that the taskqueue is closed (if it isn't already closed).
ankur22
force-pushed
the
fix/page-on-deadlock
branch
from
2a3c171
to
1f12228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This ensures that the
tasqueueis closed if it hasn't already been closed. We can now rely on the vu context when the iteration ends to clean up any remainingtaskqueues. This means that if the user forgets to usepage.closethen we will be able to close thetaskqueue.Why?
We need to closed the
taskqueueto avoid the k6 process from hanging indefinitely.Checklist
Related PR(s)/Issue(s)
Updates: #1451
Updates: #1450