Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Async examples #1368

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Fix Async examples #1368

merged 4 commits into from
Jun 4, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Jun 4, 2024 •
edited
Loading

What?

Fixes await usage.

Why?

The examples were incorrectly using await, leading to incorrect results.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@inancgumus inancgumus added bug Something isn't working documentation Improvements or additions to documentation async supports async (promises) labels Jun 4, 2024
@inancgumus inancgumus self-assigned this Jun 4, 2024
@inancgumus inancgumus requested review from ankur22 and allansson June 4, 2024 14:18
@inancgumus inancgumus marked this pull request as ready for review June 4, 2024 14:19
ankur22
ankur22 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus inancgumus merged commit b5b45e4 into main-async Jun 4, 2024
14 checks passed
@inancgumus inancgumus deleted the fix/async/examples branch June 4, 2024 14:24
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

@allansson allansson Awaiting requested review from allansson

Assignees

@inancgumus inancgumus

Labels
async supports async (promises) bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22