-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fill functionality for textarea #1238
Conversation
I would test that this works for |
Of course you can try it, if you build a custom k6 binary from the code on the branch. Fill() for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 Thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
d815a2d
to
1592cf3
Compare
Thanks @ankur22, @inancgumus, and of course @bandorko 👏🏻 What does the process look like for getting this into the next k6 release? So I know what to expect. |
It will be in the next version of k6 ( |
What?
Fixes a bug, where calling fill() on textarea throws error. #1225
Why?
fill() should work for any contenteditable node. Currently it works only for
<input>
Checklist
Related PR(s)/Issue(s)
#1225