Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a shadow DOM example #1209

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Add a shadow DOM example #1209

merged 1 commit into from
Feb 12, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Feb 9, 2024 •
edited
Loading

What?

Adds a shadow DOM E2E example test script.

Why?

To verify the behavior and redirect users to the example.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates: #1210

@inancgumus inancgumus self-assigned this Feb 9, 2024
@inancgumus inancgumus added documentation Improvements or additions to documentation tests labels Feb 9, 2024
@inancgumus inancgumus requested a review from ankur22 February 9, 2024 08:56
ankur22
ankur22 previously approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Would be nice if we could deploy our own test pages somewhere though.

examples/shadowdom.js Show resolved Hide resolved
examples/shadowdom.js Show resolved Hide resolved
examples/shadowdom.js Outdated Show resolved Hide resolved
@inancgumus inancgumus changed the title Add a shadow example Add a shadow DOM example Feb 9, 2024
@inancgumus inancgumus mentioned this pull request Feb 9, 2024
Closed
@inancgumus inancgumus requested a review from ankur22 February 9, 2024 13:40
ankur22
ankur22 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus merged commit a8e2f5e into main Feb 12, 2024
17 checks passed
@inancgumus inancgumus deleted the add/shadow-example branch February 12, 2024 10:53
@inancgumus inancgumus mentioned this pull request Feb 16, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
documentation Improvements or additions to documentation tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22