Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add goja escape assertions #1191

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Add goja escape assertions #1191

merged 2 commits into from
Jan 25, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Jan 25, 2024 •
edited
Loading

What?

  • Adds assertions for goja value escapes to ExecutionContext.
  • Marks the failing tests as skipped until we fix them all.

Note that this will be added to the fix/goja-execctx-eval branch. Then, we'll fix the failing tests in other PRs (See #1182). So it's safe to approve this.

Why?

  • To ensure that no Goja value escapes to ExecutionContext.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates: #1182

@inancgumus inancgumus self-assigned this Jan 25, 2024
@inancgumus inancgumus changed the title Fix/goja execctx assert Add goja escape assertions Jan 25, 2024
This was referenced Jan 25, 2024
Merged
Closed
@inancgumus inancgumus requested review from ankur22 and ka3de January 25, 2024 08:05
@inancgumus inancgumus added bug Something isn't working tests labels Jan 25, 2024
ankur22
ankur22 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

common/helpers.go Show resolved Hide resolved
@inancgumus inancgumus mentioned this pull request Jan 25, 2024
Open
@inancgumus inancgumus mentioned this pull request Jan 25, 2024
Merged
3 tasks
@inancgumus inancgumus merged commit 00b7f9f into fix/goja-execctx-eval Jan 25, 2024
14 checks passed
@inancgumus inancgumus deleted the fix/goja-execctx-assert branch January 25, 2024 11:40
@BrewTestBot BrewTestBot mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

@ka3de ka3de Awaiting requested review from ka3de

Assignees

@inancgumus inancgumus

Labels
bug Something isn't working tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22