Fix installer #70
Open
Fix installer #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installer script throws an error and then fails silently.
The call to tk init tries to force the k8s version to 1.22, which is no longer supported by k8s-libsonnet. This results in a Golang panic because the 1.22 files aren't found. The panic doesn't seem to block the installation, but it's there on the screen for all to see. This is fixed by removing the command line argument that forces the version to 1.22.
Later in the script, the bash read command is used to generate a dynamic config for the Grafana instrumentation.. The read works as expected, generating the dynamic config. However, by design when read finishes and encounters the EOF marker, it sets the errorlevel to 1. Because the -e option is set, even though no real error condition exists, the script exits rather than deploy the app. This is fixed by removing the read stanza and replacing it with an environment variable and command substitution.