-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drone -> Github Actions #938
Conversation
9bc0851
to
82e2d15
Compare
|
253bc6e
to
8ce56a2
Compare
From our internal Drone instance to public Github actions runners
8ce56a2
to
57c05e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one. Admittedly I didn't review the new workflows to make sure they match the previous exactly but we'll find out soon enough.
The biggest thing to watch out for here is the huge increase in arm64 build time: 41s vs. 7m53s, due to the switch from a native builder to emulation. It might be worth doing the Go build as a cross-build by setting GOARCH
instead of emulating it, to get around at least some of this.
A lot of the time is spent installing jb as well, but we could get it from their github releases instead. So yeah, some optimization could be made for sure |
Should we cut a new release to make sure that the GHA based CI system works as expected? :D |
I will. I have some speed improvements to make first |
CI was moved to GHA here: #938 However, it turns out that `buildx` is pretty slow. Improvements in this PR: - Remove `apk add curl` where easily doable - Download `jb` from Github releases rather than building it - Build `tk` exec outside of Docker
From our internal Drone instance to public Github actions runners