Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Golang 1.20 #860

Merged
merged 4 commits into from
May 10, 2023
Merged

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented May 10, 2023

  • The go version was upgraded here: https://github.com/grafana/tanka/pull/836/files but not actually in the Drone config where Tanka is actually built
  • Bump golangci-lint, it crashed with 1.20
  • Fix new linting errors from new version
  • Lock the plugins/manifest Drone plugin to v1.4.0. They broke the latest version

The go version was upgraded here: https://github.com/grafana/tanka/pull/836/files

Also, lock the `plugins/manifest` Drone plugin. They broke the latest version
@julienduchesne julienduchesne requested a review from a team May 10, 2023 15:00
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

PR Preview Action 008c651
Preview removed because the pull request was closed.
2023-05-10 16:33 UTC

@julienduchesne julienduchesne force-pushed the julienduchesne/build-with-go-1.20 branch from 2e23268 to 2829d17 Compare May 10, 2023 15:22
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice bit of de morgan's law action going on there

@julienduchesne
Copy link
Member Author

nice bit of de morgan's law action going on there

@julienduchesne julienduchesne merged commit 008c651 into main May 10, 2023
@julienduchesne julienduchesne deleted the julienduchesne/build-with-go-1.20 branch May 10, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants