Replace external call to diffstat with native code
#769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #767 `diffstat` is not available in the `apk` registry so we would have to compile it manually to add it to the docker image Parsing a diff to get the number of lines is pretty simple I tried a few external libraries but they didn't work right + less libs is better
the-it
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #767
I got nerd sniped... though it was pretty quick to implement
diffstatis not available in theapkregistry so we would have to compile it manually to add it to the docker imageSo I opted to write our own implementation of diffstat (probably much simpler than the real thing, less cases to handle)