-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Peek #467
Merged
feat(api): Peek #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new functionality called Peek with behaves like Load, but only loads metadata. Because this is much faster than full loading, this can be used at places where only metadata is required. This formalizes behavior that was previously possible by passing `EnvsOnlyEvalScript`. The benefit of having this as an interface implementation is that it can make better use of underlying details, such as that the static loader does need to start a costly Jsonnet VM for only parsing `spec.json`
Applies the Peek function at places where it makes sense
Duologic
reviewed
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much easier to review.
Duologic
reviewed
Jan 7, 2021
Duologic
reviewed
Jan 7, 2021
Duologic
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new functionality called Peek with behaves like Load, but
only loads metadata.
Because this is much faster than full loading, this can be used at
places where only metadata is required.
This formalizes behavior that was previously possible by passing
EnvsOnlyEvalScript
. The benefit of having this as an interfaceimplementation is that it can make better use of underlying details,
such as that the static loader does need to start a costly Jsonnet VM
for only parsing
spec.json