chore(docker): properly handle arm(32) and arm64 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts the previous commits attempt to fix Helm on arm32 by using the Alpine package, because as it turns out, there is no alpine package for armhf. Instead, we now use the offical Helm binaries, and `go env GOOS` and `go env GOARCH` to pick the correct one. This should work consistently across all platforms.
Uses the alpine version of golang consistently across the whole Dockerfile, so no longer need to pull both, the ubuntu and the alpine variant: use golang:alpine Uses the alpine version of golang consistently across the whole Dockerfile, so no longer need to pull both, the ubuntu and the alpine variant
|
I just verified manually, this one actually builds just fine on |
sh0rez
changed the title
Duologic
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the previous commits attempt to fix Helm on arm32 by using the Alpine package, because as it turns out, there is no alpine package for armhf.
Instead, we now use the offical Helm binaries, and
go env GOOSandgo env GOARCHto pick the correct one.This should work consistently across all platforms.