Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): use jpath tool to export JSONNET_PATH #427

Merged
merged 3 commits into from
Dec 11, 2020
Merged

feat(cmd): use jpath tool to export JSONNET_PATH #427

merged 3 commits into from
Dec 11, 2020

Conversation

Duologic
Copy link
Member

@Duologic Duologic commented Nov 23, 2020 •
edited
Loading

This allows us to export the JSONNET_PATH for use with other tools like
jsonnet-lint or jsonnet-deps.

Example:

eval $(tk tool jpath environment/prod/main.jsonnet)
jsonnet-lint environment/prod/main.jsonnet

@Duologic Duologic marked this pull request as ready for review November 23, 2020 16:10
@sh0rez
Copy link
Member

sh0rez commented Nov 23, 2020

We also have tk tool jpath, which is closely related. Also it is not incredibly useful at the moment. wdyt about adding your functionality as tk tool jpath -e for starters? Also tool jpath should accept an argument instead of using the current working dir

@Duologic Duologic force-pushed the duologic/export_jpath branch from 4522360 to 590897e Compare November 23, 2020 17:11
@Duologic Duologic changed the title feat(exportJpath): add tool to export JSONNET_PATH feat(cmd): use jpath tool to export JSONNET_PATH Nov 23, 2020
@Duologic Duologic requested a review from sh0rez November 23, 2020 17:12
@Duologic
feat(cmd): use jpath tool to export JSONNET_PATH
0bb481d 
This allows us to export the JSONNET_PATH for use with other tools like
`jsonnet-lint` or `jsonnet-deps`.

Example:

```
eval $(tk tool jpath environment/prod/main.jsonnet)
jsonnet-lint environment/prod/main.jsonnet
```
@Duologic Duologic force-pushed the duologic/export_jpath branch from 590897e to 0bb481d Compare November 23, 2020 17:13
@Duologic Duologic mentioned this pull request Nov 23, 2020
Closed
sh0rez
sh0rez requested changes Nov 24, 2020
View reviewed changes
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, some tiny details :)

cmd/tk/tool.go Outdated Show resolved Hide resolved
cmd/tk/tool.go Outdated Show resolved Hide resolved
cmd/tk/tool.go Outdated Show resolved Hide resolved
@Duologic Duologic requested a review from sh0rez November 26, 2020 19:55
@sh0rez sh0rez merged commit c06134b into master Dec 11, 2020
@sh0rez sh0rez deleted the duologic/export_jpath branch December 11, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0rez sh0rez sh0rez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Duologic @sh0rez