-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow other entrypoints #389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Will review once released |
sh0rez
added
kind/enhancement
Improve something existing
lifecycle/blocked
Blocked by outstanding changes (to another project)
labels
Sep 28, 2020
Duologic
force-pushed
the
duologic/allow_alternative_entrypoint
branch
from
October 11, 2020 15:33
6f4fd2b
to
0fc9166
Compare
rebased |
malcolmholmes
approved these changes
Oct 12, 2020
sh0rez
requested changes
Oct 12, 2020
Duologic
force-pushed
the
duologic/allow_alternative_entrypoint
branch
from
October 19, 2020 08:42
17379fc
to
65e6969
Compare
rebased. |
Duologic
removed
the
lifecycle/blocked
Blocked by outstanding changes (to another project)
label
Oct 19, 2020
sh0rez
approved these changes
Oct 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Very awesome work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change allows the user to run tanka with alternative entrypoints, not limiting to
main.jsonnet
anymore.This opens the door to using
tk eval
for purposes outside of the Tanka/K8s Environments paradigm. For example, one canwrite a library with a
test.jsonnet
and runtk eval test.jsonnet
in that library. Caveat: it needs to have atkrc.yaml
orjsonnetfile.json
so Tanka can resolve the JPATH. It also works fortk export
andtk show
, bewarethat it will add
default
namespace to kubernetes objects, even though aspec.json
might not exist.This change is backwards compatible and still defaults to main.jsonnet if no file is given,
tk diff
will still want aspec.json to connect to a cluster.
Feel free to give feedback/pushback on the idea here too.
I've done a grep on
main.jsonnet
in the codebase to set this up, but there are many other valid references tomain.jsonnet
left that don't need replacing.