feat(helm): Make name format configurable #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the keys the `helmTemplate` native func uses in the returned map configurable, by passing `nameFormat` as part of the `opts` argument.
Recently introduces `Masterminds/sprig` is now also available in the name format of `tk export` to be consistent.
Moves Jsonnet native func related code into jsonnet.go
sh0rez
added
kind/enhancement
malcolmholmes
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the key used for the map returned by
helmTemplateconfigurable.It is now permitted to pass a
nameFormatfield as part of theoptsargument that changes the default name format{{kind}}_{{name}}.To make helpful features such as
lowerorsnakecaseavailable in the template, https://github.com/Masterminds/sprig was added. This change has also been propagated to the template used intk export.Fixes #361