Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise diff error message to encourage upgrading kubectl beyond 1.18.0 #371

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Revise diff error message to encourage upgrading kubectl beyond 1.18.0 #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/kubernetes/diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func (k *Kubernetes) Diff(state manifest.List, opts DiffOpts) (*string, error) {
if k.ctl.Info().ClientVersion.Equal(semver.MustParse("1.18.0")) {
return nil, fmt.Errorf(`You seem to be using kubectl 1.18.0, which contains an unfixed issue
that makes 'kubectl diff' modify resources in your cluster.
Please downgrade kubectl until https://github.com/kubernetes/kubernetes/issues/89762 is fixed.`)
Please upgrade kubectl to at least version 1.18.1.`)
}

// required for separating
Expand Down