Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples): prom-grafana dependencies #264

Merged
merged 1 commit into from
Apr 20, 2020
Merged

fix(examples): prom-grafana dependencies #264

merged 1 commit into from
Apr 20, 2020

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Apr 19, 2020

Were installed using a development version of jb that apparently never
worked at all

@sh0rez
fix(examples): prom-grafana dependencies
f08eb47 
Were installed using a development version of jb that apparently never
worked at all
@sh0rez sh0rez added the kind/bug Something isn't working label Apr 19, 2020
@sh0rez sh0rez requested a review from slim-bean April 19, 2020 22:13
slim-bean
slim-bean approved these changes Apr 19, 2020
View reviewed changes
Copy link
Contributor

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 questions:

  • each file has a different value for legacyImports not sure if that's correct or not
  • does this just fix some syntax in the jsonnet files? looks like examples but not sure if there are any vendor files that need update?

@sh0rez
Copy link
Member Author

sh0rez commented Apr 20, 2020

each file has a different value for legacyImports not sure if that's correct or not

Yes, the lockFile always has false, I guess we should make jb omit it there

does this just fix some syntax in the jsonnet files? looks like examples but not sure if there are any vendor files that need update?

vendor is not committed at all haha

@sh0rez sh0rez merged commit 740ad7b into master Apr 20, 2020
@sh0rez sh0rez deleted the example-fix branch April 20, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sh0rez @slim-bean