Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diff): refuse to diff on kubectl 1.18 #254

Merged
merged 1 commit into from
Apr 7, 2020
Merged

fix(diff): refuse to diff on kubectl 1.18 #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/kubernetes/diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package kubernetes
import (
"fmt"

"github.com/Masterminds/semver"
"github.com/pkg/errors"

"github.com/grafana/tanka/pkg/kubernetes/client"
Expand All @@ -12,6 +13,13 @@ import (

// Diff takes the desired state and returns the differences from the cluster
func (k *Kubernetes) Diff(state manifest.List, opts DiffOpts) (*string, error) {
// prevent https://github.com/kubernetes/kubernetes/issues/89762 until fixed
if k.ctl.Info().ClientVersion.Equal(semver.MustParse("1.18.0")) {
return nil, fmt.Errorf(`You seem to be using kubectl 1.18.0, which contains an unfixed issue
sh0rez marked this conversation as resolved.
Show resolved Hide resolved
that makes 'kubectl diff' modify resources in your cluster.
Please downgrade kubectl until https://github.com/kubernetes/kubernetes/issues/89762 is fixed.`)
}

// required for separating
namespaces, err := k.ctl.Namespaces()
if err != nil {
Expand Down