feat: Prune old resources #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
added
kind/feature
Queries the required data a lot faster, by using kubectl more efficiently (one call vs a call for each kind). Can be possibly improved even further by running in parallel.
Adds a `tk prune` command, that does what it promises. Prune is functionally complete now.
sh0rez
changed the title
woodsaj
reviewed
Apr 6, 2020
woodsaj
reviewed
Apr 8, 2020
malcolmholmes
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Looked through code (there's a lot of changes!)
In one test environment, set injectLabels and saw it create labels.
Duplicated a service, and created it. Saw label added.
Removed service from jsonnet. tk apply said no changes. tk prune swiftly went through steps, then offered me a diff showing the service that was to be removed.
It then removed it.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a mechanism that allows to remove previously created resources that are no longer present in the Jsonnet code, based on internal discussion and tips from @anguslees (thanks!)
Process:
tanka.dev/environment: <env-name>tk pruneto remove old onesmetadata.uidof currently present objectsDesign doc: https://docs.google.com/document/d/1R3_dvXRb2d46GJTb3PQT3hfx2q5sy-ixifSGaWwDM8M
Fixes #88
/cc @malcolmholmes @captncraig @mplzik