-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Docz #134
feat: Docz #134
Conversation
Adds a section about doing the same task, but this time using Jsonnet and Tanka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great!
Switches from the docz wrapper to plain gatsby (much more stable)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great!
There we go @malcolmholmes, applied your review feedback.
|
Things to be done:
|
Here's some review thoughts:
|
Co-authored-by: Malcolm Holmes [email protected]
Installation of ksonnet-lib is automated, no need to elaborate it anymore
Simplified it a lot, as Tanka automatically does this now.
Switches the markdown renderer from
mkdocs
to https://docz.site. This new thing is React and Gatsbyjs based, giving us much more possibilities about the rendering. Especially it now uses the vscode highlight engine, so Jsonnet highlighting works.Furthermore I have written an entire tutorial to get new users started much easier.
PS: Don't worry, the +16k is related to
yarn.lock
(wtf)