Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): make -t case insensitive #130

Merged
merged 1 commit into from
Jan 6, 2020
Merged

fix(cli): make -t case insensitive #130

merged 1 commit into from
Jan 6, 2020

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Dec 10, 2019

was not before, but should be for better UX

Fixes #126

@sh0rez
fix(cli): make -t case insensitive
9f241c8 
was not before, but should be for better UX
@sh0rez sh0rez added kind/enhancement Improve something existing component/cli Command Line Interface labels Dec 10, 2019
@sh0rez sh0rez requested a review from replay December 10, 2019 21:31
@sh0rez sh0rez self-assigned this Dec 10, 2019
rfratto
rfratto approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sh0rez sh0rez merged commit 9f62754 into master Jan 6, 2020
@sh0rez sh0rez deleted the targets-case-insensitive branch January 6, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfratto rfratto rfratto approved these changes

@replay replay Awaiting requested review from replay

Assignees

@sh0rez sh0rez

Labels
component/cli Command Line Interface kind/enhancement Improve something existing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tk diff -t requires the resource type to be lower case
2 participants
@sh0rez @rfratto