Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes/diff): check correctly & ignore apiVersion #12

Merged
merged 5 commits into from
Aug 7, 2019
Merged

fix(kubernetes/diff): check correctly & ignore apiVersion #12

merged 5 commits into from
Aug 7, 2019

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Aug 7, 2019

version check was broken, now auto choose should work correctly

ignores apiVersion, too messy for now

@sh0rez sh0rez added kind/bug Something isn't working component/kubernetes Working with Kubernetes clusters labels Aug 7, 2019
@sh0rez sh0rez requested a review from tomwilkie August 7, 2019 10:54
@sh0rez sh0rez self-assigned this Aug 7, 2019
sh0rez added 3 commits August 7, 2019 15:30
@sh0rez
fix(kubernetes/diff): check correctly & ignore apiVersion
3e19451 
version check was broken, now auto choose should work correctly

ignores apiVersion, too messy for now
@sh0rez
fix(kubernetes/diff): subsetdiff index out of range
6f0eb49 
When a slice in the live system was larger than in the config, it lead to a
panic. This change makes the subset algorithm abort for the slice in this case,
as there are no entries to diff against anymore
@sh0rez
perf(kubernetes/diff): calculate subset in parallel
41988ea
@sh0rez
refactor(kubernetes/diff): do not invoke diff in parallel
4e93fe2 
does not really improve performance but hurts readability
gouthamve
gouthamve reviewed Aug 7, 2019
View reviewed changes
Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single letter and 2 letter variable names are super hostile to new comers and should be avoided as much as possible. other than that, this makes sense.

pkg/kubernetes/subsetdiff.go Outdated Show resolved Hide resolved
pkg/kubernetes/subsetdiff.go Outdated Show resolved Hide resolved
pkg/kubernetes/subsetdiff.go Outdated Show resolved Hide resolved
pkg/kubernetes/subsetdiff.go Outdated Show resolved Hide resolved
pkg/kubernetes/subsetdiff.go Outdated Show resolved Hide resolved
pkg/kubernetes/subsetdiff.go Outdated Show resolved Hide resolved
@sh0rez sh0rez merged commit 3248bb9 into master Aug 7, 2019
@sh0rez sh0rez deleted the subsetdiff-fix branch August 7, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouthamve gouthamve gouthamve approved these changes

@tomwilkie tomwilkie tomwilkie approved these changes

Assignees

@sh0rez sh0rez

Labels
component/kubernetes Working with Kubernetes clusters kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sh0rez @tomwilkie @gouthamve