Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Redesign check type selection screen #957

Merged
merged 19 commits into from
Nov 11, 2024
Merged

Conversation

VikaCep
Copy link
Contributor

@VikaCep VikaCep commented Oct 7, 2024

Redesigns the check type selection screen.

  • New icons for all check types.
  • New badge to highlight browser checks.
  • A clear indicator, using the "i" icon, to show whether a check is public or private.
  • Updated descriptions for some check types, fitting within 3-row paragraphs.
  • A clarified tooltip explaining that browser checks are currently in public preview and can be used without charge for test executions.
  • More concise call-to-action buttons, removing redundant "Create" and "Check" text.
  • Textual links instead of badges to showcase supported types for each check, ensuring they do not overshadow the primary call to action.

image

Closes #955

@VikaCep
Copy link
Contributor Author

VikaCep commented Oct 8, 2024

New icons added in grafana/grafana#94439

@VikaCep VikaCep marked this pull request as ready for review October 8, 2024 20:35
@VikaCep VikaCep requested a review from a team as a code owner October 8, 2024 20:35
@VikaCep VikaCep force-pushed the 955-cart-layout-redesign branch from b94c5d3 to 02aac44 Compare October 18, 2024 13:49
@VikaCep VikaCep requested review from w1kman and ckbedwell October 18, 2024 14:00
@VikaCep
Copy link
Contributor Author

VikaCep commented Oct 18, 2024

This PR needs Grafana 11.3.0 to be released in order to use the new icons, which is scheduled for 2024-10-22 (as of https://internal-ops-us-east-0.grafana.net/grafana-release-guide/release-schedule/)
Leaving that aside, we can start reviewing it.

@VikaCep VikaCep force-pushed the 955-cart-layout-redesign branch from 98c2325 to 372a2fc Compare October 23, 2024 20:18
@VikaCep
Copy link
Contributor Author

VikaCep commented Oct 23, 2024

Ok, it seems the new icons weren't included in grafana 11.3.0 as the PR was merged after the cut, which was Oct 4, so we'll have to wait for that release to take place in order to consume these icons 😞

image image

@VikaCep
Copy link
Contributor Author

VikaCep commented Oct 23, 2024

Because of this, we would need to wait for grafana version 11.4.0 in order to use the new icons. And according to this document, version 11.4.0 is scheduled for release on December 5, which feels quite far off.

To move forward, I’ve reverted to using the old icons while keeping the rest of the card redesign that Maja proposed. This will allow us to review and merge these changes sooner, and once the new icons are ready, we can easily update them in a new PR.

image

@VikaCep VikaCep changed the title feat: redesign check type selection screen Redesign check type selection screen Oct 29, 2024
Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Code looks good, just a few extra things to address:

I am sure @majavojnoska would like these to default to 2 x 2 when we can't get four cards on the same row.

The check type group cards in Synthetic Monitoring at a medium laptop size. The top row has 3 cards on it and a single one on the second row.

And similar for when we go down to 1 per row, can we make this prettier, too?

The check type cards in Synthetic Monitoring at a large mobile size. The cards are left aligned and leave a lot of blank space to the right.

And on the check creation page can we add the accompanying badge to the left of the icon. There is also a bug about where the toggletip is rendering, can you see what is going on there? 🤔

New browser check creation page in Synthetic Monitoring. The toggletip is open but not displayed near the accompanying icon it is associated with.

src/components/ChooseCheckGroup/ChooseCheckGroup.test.tsx Outdated Show resolved Hide resolved
@VikaCep
Copy link
Contributor Author

VikaCep commented Oct 30, 2024

This is great! Code looks good, just a few extra things to address:
I am sure @majavojnoska would like these to default to 2 x 2 when we can't get four cards on the same row.

And similar for when we go down to 1 per row, can we make this prettier, too?

I changed the layout to prevent having 3 columns. According to the breakpoints defined in grafana/ui, it's showing either 1, 2 or 4 columns.

xs
image
sm
image
md
image
lg
image
xl
image
xxl
image

And on the check creation page can we add the accompanying badge to the left of the icon.

I also added the NEW badge in the check form :)

image

@majavojnoska
Copy link

This looks awesome Vika! ❤️

@VikaCep VikaCep requested a review from ckbedwell November 1, 2024 13:38
- workaround to fix the bug in floating-ui when setting containerType: inline-size
- more info here floating-ui/floating-ui#3067
@w1kman
Copy link
Contributor

w1kman commented Nov 5, 2024

Unfortunately, this is how it looks on Windows 🪟
image

Copy link
Contributor

@w1kman w1kman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look so fresh on a Windows machine with the scrollbars
image

src/components/ChooseCheckGroup/Protocol.tsx Outdated Show resolved Hide resolved
src/hooks/useCheckTypeGroupOptions.tsx Outdated Show resolved Hide resolved
src/hooks/useCheckTypeGroupOptions.tsx Outdated Show resolved Hide resolved
src/hooks/useCheckTypeGroupOptions.tsx Show resolved Hide resolved
@VikaCep VikaCep requested a review from w1kman November 5, 2024 15:49
Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few changes to tighten up 🔧

src/components/CheckForm/FormLayout/FormSection.tsx Outdated Show resolved Hide resolved
src/components/CheckForm/FormLayout/FormSection.tsx Outdated Show resolved Hide resolved
src/components/ChooseCheckGroup/CheckGroupCard.tsx Outdated Show resolved Hide resolved
src/components/ChooseCheckGroup/CheckGroupCard.tsx Outdated Show resolved Hide resolved
src/components/ChooseCheckGroup/CheckGroupCard.tsx Outdated Show resolved Hide resolved
src/components/ChooseCheckGroup/ChooseCheckGroup.tsx Outdated Show resolved Hide resolved
@VikaCep VikaCep requested a review from ckbedwell November 6, 2024 19:29
@VikaCep
Copy link
Contributor Author

VikaCep commented Nov 7, 2024

Last few changes to tighten up 🔧

Thanks Chris! I've applied your suggestions 🙏

Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@VikaCep VikaCep merged commit e3c91c1 into main Nov 11, 2024
5 checks passed
@VikaCep VikaCep deleted the 955-cart-layout-redesign branch November 11, 2024 14:16
@VikaCep VikaCep changed the title Redesign check type selection screen feat: Redesign check type selection screen Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better card layout for "Choose a check type" page
4 participants