Add scripted checks #647
Merged
Add scripted checks #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to add-scripted-checks
|
@ckbedwell I'm interested in your thoughts on how to proceed here. The feature is obviously very much a WIP, but as you can see the PR is already getting too big for it's britches. I'm inclined to merge it since it's behind a feature flag, and then bite off smaller pieces in more manageable PRs |
mem
approved these changes
Nov 14, 2023
ckbedwell
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
@rdubrock I agree, let's get this in and then we can review it in full when it is nearing release-ready. There's a lot to digest in this PR and I've looked through most of it but I don't think there is any need to hold this up 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: