fix: disable hasUnsavedChanges prop for now #1025
Draft
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VikaCep
approved these changes
Dec 19, 2024
|
Changed to draft as we did a rollback on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: When using the "Test" button in the CheckForm, the form is technically submitted but not saved. After testing, the formState is no longer "dirty", which results in the "Save" button being disabled and the "You have unsaved changes" dialog to not appear.
This fix removes the logic that disables the "Save" button when the formState is clean.
This fix DOES NOT resolve the fact that a user can navigate away from an unsaved check without getting prompted.
Which issue(s) this PR fixes:
Resolves #1024
Special notes for your reviewer: